lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 37/75] IB/srpt: Set srq_type to IB_SRQT_BASIC
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit 6f3603367b8f7c34598fdfc1058622e0e1951e98 upstream.

    Since commit 96104eda0169 ("RDMA/core: Add SRQ type field"), kernel
    users of SRQs need to specify srq_type = IB_SRQT_BASIC in struct
    ib_srq_init_attr, or else most low-level drivers will fail in
    when srpt_add_one() calls ib_create_srq() and gets -ENOSYS.

    (mlx4_ib works OK nearly all of the time, because it just needs
    srq_type != IB_SRQT_XRC. And apparently nearly everyone using
    ib_srpt is using mlx4 hardware)

    Reported-by: Alexey Shvetsov <alexxy@gentoo.org>
    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/ulp/srpt/ib_srpt.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
    +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
    @@ -3225,6 +3225,7 @@ static void srpt_add_one(struct ib_devic
    srq_attr.attr.max_wr = sdev->srq_size;
    srq_attr.attr.max_sge = 1;
    srq_attr.attr.srq_limit = 0;
    + srq_attr.srq_type = IB_SRQT_BASIC;

    sdev->srq = ib_create_srq(sdev->pd, &srq_attr);
    if (IS_ERR(sdev->srq))



    \
     
     \ /
      Last update: 2012-04-19 23:13    [W:0.052 / U:29.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site