lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 07/12] drivers: media: video: tm6000: tm6000.h: Include version.h header
    Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
    > The output of "make versioncheck" told us that:
    >
    > drivers/media/video/tm6000/tm6000.h: 401: need linux/version.h
    >
    > If we take a look at the code, we can see the use of the macro
    > KERNEL_VERSION. So, we need this include.
    >
    > In this patch too, the headers of the file were reordered in alphabetic
    > order. No functional changes here.
    >
    > Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
    > Cc: <linux-media@vger.kernel.org >
    > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

    Nack. See enclosed.

    commit d8a9c01484b258573587a52c3226bbdf6d11cda6
    Author: Mauro Carvalho Chehab <mchehab@redhat.com>
    Date: Thu Apr 19 16:35:27 2012 -0300

    [media] tlg2300: Remove usage of KERNEL_VERSION()

    As reported by Marcos:

    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
    > The output of "make versioncheck" told us that:
    >
    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
    >
    > If we take a look at the code, we can see that this file uses the macro
    > KERNEL_VERSION.

    The V4L2 core now fills it automatically, so drivers shouldn't touch on
    cap->version anymore.

    Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

    diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
    index a794ae6..bfbf9e5 100644
    --- a/drivers/media/video/tlg2300/pd-video.c
    +++ b/drivers/media/video/tlg2300/pd-video.c
    @@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
    strcpy(cap->driver, "tele-video");
    strcpy(cap->card, "Telegent Poseidon");
    usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
    - cap->version = KERNEL_VERSION(0, 0, 1);
    cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
    V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
    V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

    \
     
     \ /
      Last update: 2012-04-19 21:51    [W:0.028 / U:1.304 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site