lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clocksource, prevent overflow in clocksource_cyc2ns
On Thu, 19 Apr 2012, Prarit Bhargava wrote:
> On 04/19/2012 08:52 AM, Thomas Gleixner wrote:
> > On Thu, 19 Apr 2012, Thomas Gleixner wrote:
> >
> >> On Wed, 18 Apr 2012, John Stultz wrote:
> >>> On 04/18/2012 04:59 PM, Prarit Bhargava wrote:
> >>>>
>
> >> No. The show_state() part prints into the buffer. But it's not
> >> guaranteed that the buffer is flushed right away. It could be flushed
> >> later as well in a different context. And of course the flush code
> >> runs with interrupts disabled and dumping out a gazillion of lines
> >> over serial will cause the same hickup. Just planting random
> >> touch_watchdog() calls into the code is not the right approach,
> >> really.
> >>
> >> We should think about the reasons why we have interrupts disabled for
> >> so much time. Is that really, really necessary ?
>
> In the case of the sysrq-t, I would argue that it is. The whole point behind
> the sysrq-t is that we're capturing the *current* state of the system. Having
> that output effected by interrupts seems like a bad idea.

Nonsense. The system state can change, while we are dumping it unless
you run on an UP system. irq disable only affects the current CPU
nothing else, and nothing can prevent the other cpus to wake up, run,
exit, fork .....
Thanks,

tglx




\
 
 \ /
  Last update: 2012-04-19 15:21    [W:0.716 / U:0.768 seconds]
©2003-2014 Jasper Spaans. Advertise on this site