lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] HSI: hsi_char: Remove max_data_size from sysfs
    Date
    Remove max_data_size sysfs entry. Otherwise is possible
    to have a buffer overrun if its value is increased after
    the device is open.

    Signed-off-by: Carlos Chinea <carlos.chinea@nokia.com>
    ---
    drivers/hsi/clients/hsi_char.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
    index 88a050d..3ad91f6 100644
    --- a/drivers/hsi/clients/hsi_char.c
    +++ b/drivers/hsi/clients/hsi_char.c
    @@ -123,7 +123,7 @@ struct hsc_client_data {
    static unsigned int hsc_major;
    /* Maximum buffer size that hsi_char will accept from userspace */
    static unsigned int max_data_size = 0x1000;
    -module_param(max_data_size, uint, S_IRUSR | S_IWUSR);
    +module_param(max_data_size, uint, 0);
    MODULE_PARM_DESC(max_data_size, "max read/write data size [4,8..65536] (^2)");

    static void hsc_add_tail(struct hsc_channel *channel, struct hsi_msg *msg,
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2012-04-19 14:09    [W:0.026 / U:0.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site