[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kvm: lock slots_lock around device assignment
On Tue, Apr 17, 2012 at 09:46:44PM -0600, Alex Williamson wrote:
> As pointed out by Jason Baron, when assigning a device to a guest
> we first set the iommu domain pointer, which enables mapping
> and unmapping of memory slots to the iommu. This leaves a window
> where this path is enabled, but we haven't synchronized the iommu
> mappings to the existing memory slots. Thus a slot being removed
> at that point could send us down unexpected code paths removing
> non-existent pinnings and iommu mappings. Take the slots_lock
> around creating the iommu domain and initial mappings as well as
> around iommu teardown to avoid this race.
> Signed-off-by: Alex Williamson <>

Applied, thanks.

 \ /
  Last update: 2012-04-19 13:45    [W:0.054 / U:45.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site