lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] clk: select CLKDEV_LOOKUP for COMMON_CLK
    On Tue, Apr 17, 2012 at 03:13:49PM -0700, Turquette, Mike wrote:
    > On Mon, Apr 9, 2012 at 1:24 PM, Rob Herring <robherring2@gmail.com> wrote:
    > > From: Rob Herring <rob.herring@calxeda.com>
    > >
    > > Using the common clock infrastructure without the common clkdev code makes
    > > little sense, so select CLKDEV_LOOKUP for COMMON_CLK.
    > >
    > > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
    > > ---
    > >  drivers/clk/Kconfig |    1 +
    > >  1 files changed, 1 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
    > > index 165e1fe..f05a60d 100644
    > > --- a/drivers/clk/Kconfig
    > > +++ b/drivers/clk/Kconfig
    > > @@ -12,6 +12,7 @@ config HAVE_MACH_CLKDEV
    > >  config COMMON_CLK
    > >        bool
    > >        select HAVE_CLK_PREPARE
    > > +       select CLKDEV_LOOKUP
    > >        ---help---
    > >          The common clock framework is a single definition of struct
    > >          clk, useful across many platforms, as well as an
    >
    > Hi Rob,
    >
    > I agree that the common clk framework is not particularly useful
    > without clkdev. However the core code has no dependency on clkdev.
    > Why not just select it from an arch Kconfig, or even make it a
    > dependency based on your own platform clock data/code?

    Selecting it from COMMON_CLK means that the compiler/linker will point
    everybody trying to implement it without CLKDEV into the right
    direction.

    Sascha


    --
    Pengutronix e.K. | |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-18 22:37    [W:0.029 / U:149.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site