lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] regulator: 88pm8607: Fix writting value to vol_reg in pm8607_set_voltage_sel
    From
    Date
    commit 4ca1e1d "regulator: Convert 88pm8607 to set_voltage_sel" accidentally
    changed the value writing to vol_reg.
    What we want is to write val instead of selector to vol_reg.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    This only impact is setting LDO13, for other LDOs/BUCKs the shift is 0.

    drivers/regulator/88pm8607.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
    index d04fbe9..06d9c4b 100644
    --- a/drivers/regulator/88pm8607.c
    +++ b/drivers/regulator/88pm8607.c
    @@ -232,7 +232,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)
    val = (uint8_t)(selector << info->vol_shift);
    mask = (rdev->desc->n_voltages - 1) << info->vol_shift;

    - ret = pm860x_set_bits(info->i2c, info->vol_reg, mask, selector);
    + ret = pm860x_set_bits(info->i2c, info->vol_reg, mask, val);
    if (ret)
    return ret;
    switch (info->desc.id) {
    --
    1.7.5.4




    \
     
     \ /
      Last update: 2012-04-19 05:19    [W:0.021 / U:119.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site