lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kvm: lock slots_lock around device assignment
On Tue, Apr 17, 2012 at 09:46:44PM -0600, Alex Williamson wrote:
> @@ -340,7 +343,11 @@ int kvm_iommu_unmap_guest(struct kvm *kvm)
> if (!domain)
> return 0;
>
> + mutex_lock(&kvm->slots_lock);
> kvm_iommu_unmap_memslots(kvm);
> + kvm->arch.iommu_domain = NULL;
> + mutex_unlock(&kvm->slots_lock);
> +
> iommu_domain_free(domain);
> return 0;
> }

This might trigger lockdep warnings due to

kvm_vm_ioctl_create_vcpu
mutex_lock(&kvm->lock)
kvm_put_kvm(kvm)
kvm_destroy_vm
kvm_iommu_unmap_guest

sequence.

Better drop it, it is not necessary in vm destruction
path (since only user is self).



\
 
 \ /
  Last update: 2012-04-19 04:37    [W:0.059 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site