Messages in this thread | | | Date | Wed, 18 Apr 2012 16:48:37 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo |
| |
On 04/18/2012 03:55 PM, H.J. Lu wrote: > On Wed, Apr 18, 2012 at 2:24 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> Something like this works for you? >> >> Note: we should promote __compat_[us]64 to a global type when we do the >> cleanup work requested by Linus (change __[us]64 to explicitly aligned >> types, with all users that require the old types using __compat_[us]64), >> but we need the compiler warning to do that, realistically. >> > > Can we also align struct siginfo to 8byte for x32? >
We could. If we want to align the substructures then we need some major surgery to the compat_siginfo handling though.
-hpa
| |