lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irqdomain: print a warning if domains contain IRQ 0
From
Date
On Wed, 2012-04-18 at 15:40 +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Some of the clients using IRQ domains from the ARM VIC
> (arch/arm/common/vic.c) don't know that their (hardware) IRQ 0
> is silently ignored by the IRQ core, they will just notice
> that they're not getting this IRQ anymore. So print a warning
> if a domain contains IRQ 0 (NO_IRQ) so we get some noise about
> it atleast.

I don't understand. HW IRQ 0 is not ignored and works perfectly
fine on "normal" remapped domains. Or is this specific to "legacy
domains" ? In this case pls make it clear in the subject :-)

Cheers,
Ben.

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> kernel/irq/irqdomain.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 0e0ba5f..1444454 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -136,8 +136,10 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
> int hwirq = first_hwirq + i;
>
> /* IRQ0 gets ignored */
> - if (!irq)
> + if (!irq) {
> + pr_warn("trying to register IRQ 0 (NO_IRQ) in an irq domain\n");
> continue;
> + }
>
> /* Legacy flags are left to default at this point,
> * one can then use irq_create_mapping() to




\
 
 \ /
  Last update: 2012-04-19 00:25    [from the cache]
©2003-2011 Jasper Spaans