| Date | Wed, 18 Apr 2012 18:50:07 +0000 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 21/43] userns: Convert sched_set_affinity and sched_set_scheduler's permission checks |
| |
Quoting Eric W. Beiderman (ebiederm@xmission.com): > From: Eric W. Biederman <ebiederm@xmission.com> > > - Compare kuids with uid_eq > - kuid are uniuqe across all user namespaces so there is no longer the > need for a user_namespace comparison. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> --- > kernel/sched/core.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 96bff85..b189fec 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4042,11 +4042,8 @@ static bool check_same_owner(struct task_struct *p) > > rcu_read_lock(); > pcred = __task_cred(p); > - if (cred->user_ns == pcred->user_ns) > - match = (cred->euid == pcred->euid || > - cred->euid == pcred->uid); > - else > - match = false; > + match = (uid_eq(cred->euid, pcred->euid) || > + uid_eq(cred->euid, pcred->uid)); > rcu_read_unlock(); > return match; > } > -- > 1.7.2.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
|