lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo
    From
    On Wed, Apr 18, 2012 at 10:47 AM, H. Peter Anvin <hpa@zytor.com> wrote:
    > On 04/18/2012 10:38 AM, H.J. Lu wrote:
    >>
    >> It doesn't match struct siginfo in include/asm-generic/siginfo.h for
    >> x32.
    >>
    >
    > What is missing (from either)?
    >

    include/asm-generic/siginfo.h has

    /* SIGCHLD */
    struct {
    __kernel_pid_t _pid; /* which child */
    __ARCH_SI_UID_T _uid; /* sender's uid */
    int _status; /* exit code */
    __kernel_clock_t _utime;
    __kernel_clock_t _stime;
    } _sigchld;


    Although x32 __kernel_clock_t is s64 with 64bit alignment, in
    _sigchld, it must be compat_s64 with 32bit alignment.

    --
    H.J.


    \
     
     \ /
      Last update: 2012-04-18 22:37    [W:0.025 / U:58.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site