lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] fs/fuse: Convert to kstrtoul_from_user
    Date
    Peter Huewe <peterhuewe@gmx.de> writes:

    > This patch replaces the code for getting an number from a
    > userspace buffer by a simple call to kstroul_from_user.
    > This makes it easier to read and less error prone.

    Thanks, applied.

    Miklos

    >
    > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
    > ---
    > fs/fuse/control.c | 10 ++--------
    > 1 files changed, 2 insertions(+), 8 deletions(-)
    >
    > diff --git a/fs/fuse/control.c b/fs/fuse/control.c
    > index 42593c5..03ff5b1 100644
    > --- a/fs/fuse/control.c
    > +++ b/fs/fuse/control.c
    > @@ -75,19 +75,13 @@ static ssize_t fuse_conn_limit_write(struct file *file, const char __user *buf,
    > unsigned global_limit)
    > {
    > unsigned long t;
    > - char tmp[32];
    > unsigned limit = (1 << 16) - 1;
    > int err;
    >
    > - if (*ppos || count >= sizeof(tmp) - 1)
    > - return -EINVAL;
    > -
    > - if (copy_from_user(tmp, buf, count))
    > + if (*ppos)
    > return -EINVAL;
    >
    > - tmp[count] = '\0';
    > -
    > - err = strict_strtoul(tmp, 0, &t);
    > + err = kstrtoul_from_user(buf, count, 0, &t);
    > if (err)
    > return err;


    \
     
     \ /
      Last update: 2012-04-18 22:37    [W:0.036 / U:120.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site