lkml.org 
[lkml]   [2012]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: osd_req_encode_op() breakage?
    On Wed, Apr 18, 2012 at 10:09:05AM -0500, Alex Elder wrote:

    > Yes, you are absolutely correct.
    >
    > We have obviously not done endianness checks in this code for
    > some time.
    >
    > I will commit a fix and credit you for it. I'll also make sure
    > we are doing proper testing for this sort of thing on a regular
    > basis.

    FWIW, that got caught by sparse, but I would really recommend _testing_
    on big-endian - getting an emulated headless e.g. mips box is fairly
    easy with qemu; I'd done that with debian big-endian mips userland on
    emulated malta and it didn't take much work to set up.

    Speaking of sparse, I think we simply ought to add -D__CHECK_ENDIAN__
    to CHECKFLAGS in top-level Makefile. It's not _that_ much noise
    these days... Not sure which tree should that go through, though...


    \
     
     \ /
      Last update: 2012-04-18 22:37    [W:0.031 / U:35.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site