lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: KGTP (Linux Kernel debugger and tracer) 20120406 release(hotcode analyzer hotcode.py can output html) include patch for review
    From
    Date
    Hi Hui,

    On Sat, 2012-04-07 at 20:21 +0800, Hui Zhu wrote:
    > Signed-off-by: Hui Zhu <teawater@gmail.com>

    You have done some interesting work, but can I recommend a
    few things?

    Please break your patch into a few smaller ones, say, one
    that adds the core kgtp support, one that adds the
    documentation files, one that adds the scripts. Each patch
    should have a suitable comment that describes the
    changes. For kgtp the patch for the core support would
    of course have a discussion of the feature and its
    benefits, etc.

    Also, please post your patches inline so we can give
    line-by-line comments. It is difficult to give comments
    when the patch is an email attachment.

    -Geoff




    \
     
     \ /
      Last update: 2012-04-18 22:37    [W:0.020 / U:1.248 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site