[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] x86/mce: Avoid reading every machine check bank register twice.
    On Tue, Apr 17, 2012 at 11:37 AM, Borislav Petkov <> wrote:
    > Why, is Waldo hidden somewhere in this patch for us to find?
    I leave a couple of easy things for people to nit-pick ... it makes feel
    useful when they find stuff to complain about :-)

    >> +                     while (++i < banks)
    >> +                             __set_bit(i, hintp);
    > I'm guessing this is there so that whenever we have a serious MCE
    > worth of panic, we want to look at the remaining banks no matter their
    > validity?
    Correct. I didn't want to change the functionality of do_machine_fault()
    [even though it doesn't currently handle finding multiple errors very
    well - we ought to allow it to see everything]
    > Why not continue through the banks, filling up the hint bitmap but make
    > a note to yourself here that we'll be returning 1 when finished?

    That's probably a better idea. We don't gain much by breaking
    the loop early - might as well let all the cpus do the full scan of
    all the banks in parallel.

    >>       DECLARE_BITMAP(toclear, MAX_NR_BANKS);
    >> +     DECLARE_BITMAP(hint, MAX_NR_BANKS);
    > Maybe call it 'toread' like the toclear above so that we know what it
    > means? Or even better, valid_banks or something...?

    See - you found Waldo (I suck at choosing good names). valid_banks
    has a good sound to it.

    Thanks - I will respin a v2 soon.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-04-18 22:37    [W:0.022 / U:13.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site