lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.
    >> >> +void __init imx_cpuidle_set_driver(struct cpuidle_driver *p)
    >> >> +{
    >> >> +     drv = p;
    >> >> +}
    >> >
    >> > You like it complicated, eh? Why do you introduce a function which sets
    >> > a variable...
    >> >
    >>
    >> This complication is used to deal with the timing of various levels of
    >> init calls.  More explanation below.
    >>
    >> >> +
    >> >> +void imx_cpuidle_devices_uninit(void)
    >> >> +{
    >> >> +     int cpu_id;
    >> >> +     struct cpuidle_device *dev;
    >> >> +
    >> >> +     for_each_possible_cpu(cpu_id) {
    >> >> +             dev = per_cpu_ptr(imx_cpuidle_devices, cpu_id);
    >> >> +             cpuidle_unregister_device(dev);
    >> >> +     }
    >> >> +
    >> >> +     free_percpu(imx_cpuidle_devices);
    >> >> +}
    >> >> +
    >> >> +static int __init imx_cpuidle_init(void)
    >> >
    >> > ... instead of passing it directly to the function which uses it?
    >> >
    >>
    >> If I called imx_cpuidle_init directly from imx5 or imx6q init
    >> routines, it would be getting called before the coreinit_call of core
    >> cpuidle causing a failure.  There were various other directions to
    >> take and all seemed less desirable than this one.
    >>
    >> One alternative would be to add a function to return the pointer to
    >> the cpuidle driver object based on the machine type.  Functionality
    >> exists to identify imx5 as a machine type but not imx6q, so I couldn't
    >> use that machine based method without adding that extra code.
    >>
    >> Another alternative would be to add a general platform lateinit_call
    >> function to each platforms that support cpuidle.
    >
    > Just put the initcall into mm-imx5.c and check the cpu type. Then you
    > also don't have to make imx5_idle global.

    That solution is currently available for imx5 but for imx6q it implies
    adding the cpu type support for imx6q. Are you ok with that?

    >
    > Sascha
    >
    >
    > --
    > Pengutronix e.K.                           |                             |
    > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
    > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
    > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-17 21:35    [W:5.513 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site