lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call
Date
Steve Dickson <SteveD@redhat.com> writes:

> True, but even so... Giving file systems an opt-out option with the
> default being out, maybe still have some merit... Making file systems
> enable this new type of functionality would cut down on any of the
> "surprise" that might occur with this redo ;-)

I've been arguing for something slightly different for quite some time:
I never liked errno values which have side effects in the kernel yet
might be visible to userspace.

So why not introduce ERETRYSTALE, a *kernel internal* errno value that
userspace will never see and filesystems never accidentally set. The
VFS can turn this into ESTALE if it doesn't retry for some reason
(e.g. already retried).

Thanks,
Miklos


\
 
 \ /
  Last update: 2012-04-17 16:29    [W:0.312 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site