Messages in this thread | | | Date | Mon, 16 Apr 2012 19:30:53 -0700 | From | Greg KH <> | Subject | Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs |
| |
On Tue, Apr 17, 2012 at 09:52:42AM +0800, zhangyanfei wrote: > 于 2012年04月13日 07:00, Greg KH 写道: > > On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > >> This patch creates sysfs file to export where VMCSINFO is allocated, > >> as below: > >> $ cat /sys/kernel/vmcsinfo > >> 1cb88a0 2000 > >> number on the left-hand side is the physical address of VMCSINFO, > >> while the one on the right-hand side is the max size of VMCSINFO. > > > > Ick, why do you have 2 values in one sysfs file, that's not nice, or > > good. > > > > What's wrong with 2 different files? > > > > The reason why I put the 2 values in one sysfs file is that there is a similar > file 'vmcoreinfo' in sysfs. > # cat /sys/kernel/vmcoreinfo > 1d75380 1000
Then that should be fixed as well, using two different file names now :(
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |