lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [REGRESSION] rtc/interface.c: kills suspend-to-ram
On 04/16/2012 07:23 AM, richard -rw- weinberger wrote:
> On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<kernel@teksavvy.com> wrote:
>> Speaking of which -- that batch of RTC updates is riddled with bugs.
>> For example, this beauty from rtc-mpc5121.c in the same update:
>>
>> ...
>> rtc->rtc = rtc_device_register("mpc5200-rtc",&op->dev,
>> &mpc5200_rtc_ops, THIS_MODULE);
>> ...
>>
>> rtc->rtc->uie_unsupported = 1; //<<<< Ooops NULL pointer>>>>
>>
>> if (IS_ERR(rtc->rtc)) { //<<<< this needs to be earlier>>>>
>> err = PTR_ERR(rtc->rtc);
>> goto out_free_irq;
>> }
>> ...
>>
>>

Thanks for noticing this and CC'ing me. I'll spin up a fix promptly for
review.
-john



\
 
 \ /
  Last update: 2012-04-16 23:15    [W:0.072 / U:111.564 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site