lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] checkpatch: revert --strict test for net/ and drivers/net block comment style
    From
    Date
    Revert the --strict test for the old preferred block
    comment style in drivers/net and net/

    Signed-off-by: Joe Perches <joe@perches.com>

    ---

    grumble. Don't reply to email from internet cafes.

    On Mon, 2012-04-16 at 12:44 -0700, Randy Dunlap wrote:
    > On 04/16/2012 02:17 AM, Ingo Molnar wrote:
    > > aad4f6149831 checkpatch: add --strict tests for braces, comments and casts
    > > made the default checkpatch run complain about the following
    > > perfectly fine multi-line comment block:

    No, it didn't.

    It only made checkpatch complain if --strict was
    added to the command line arguments.

    I don't care about the comment style, it is/was
    David Miller's preferred style for drivers/net and
    net/

    I think a straight revert isn't appropriate.

    Here's one that just removes the comment check.

    scripts/checkpatch.pl | 6 ------
    1 files changed, 0 insertions(+), 6 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index de639ee..faea0ec 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1869,12 +1869,6 @@ sub process {
    "No space is necessary after a cast\n" . $hereprev);
    }

    - if ($rawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
    - $prevrawline =~ /^\+[ \t]*$/) {
    - CHK("BLOCK_COMMENT_STYLE",
    - "Don't begin block comments with only a /* line, use /* comment...\n" . $hereprev);
    - }
    -
    # check for spaces at the beginning of a line.
    # Exceptions:
    # 1) within comments



    \
     
     \ /
      Last update: 2012-04-16 21:39    [W:0.028 / U:28.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site