Messages in this thread |  | | | Date | Mon, 16 Apr 2012 18:58:10 +0200 | | From | Samuel Ortiz <> | | Subject | Re: [PATCH] mfd: asic3: fix asic3_gpio_to_irq |
| |
Hi Dmitry,
On Thu, Apr 12, 2012 at 03:33:34PM +0400, Dmitry Artamonow wrote: > Assumption that irq numbers of asic3 gpios start at > IRQ_BOARD_START is certainly wrong - driver may as well > use any other base for its irqs (consider for example > the imaginary case of two ASIC3 chips onboard) > > Furthermore, some platforms even don't have IRQ_BOARD_START > defined, so driver will fail to build on them: > ------------------------------------------------------- > drivers/mfd/asic3.c: In function 'asic3_gpio_to_irq': > drivers/mfd/asic3.c:530: error: 'IRQ_BOARD_START' undeclared (first use in this function) > drivers/mfd/asic3.c:530: error: (Each undeclared identifier is reported only once > drivers/mfd/asic3.c:530: error: for each function it appears in.) > ------------------------------------------------------- > > Fix it by using irq_base from driver data. > > Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru> > --- > drivers/mfd/asic3.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Thanks, I applied this one to my for-linus branch.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
|  |