lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver
On Mon, 16 Apr 2012, Roland Stigge wrote:

> On 04/16/2012 05:09 PM, Alan Stern wrote:
> >> drivers/usb/Makefile | 5 ++
> >> drivers/usb/misc/Kconfig | 12 ++++++
> >> drivers/usb/misc/Makefile | 1
> >> drivers/usb/misc/isp1301.c | 64 ++++++++++++++++++++++++++++++++++
> >> include/linux/usb/isp1301.h | 82 ++++++++++++++++++++++++++++++++++++++++++++
> >
> > You know, drivers/usb/misc is meant for miscellaneous USB device
> > drivers. Not for host or transceiver drivers.
> >
> > You should put the new file somewhere else. Maybe in the otg
> > directory, although that may not be completely appropriate either.
> > Maybe something under the host directory.
>
> The driver is used by drivers in the following directories:
>
> drivers/usb/host/ (ohci-nxp.c)
> drivers/usb/otg/ (isp1301_omap.c)
> drivers/usb/gadget/ (lpc32xx_udc.c)
>
> So host/ and otg/ don't look much better.
>
> Maybe one of (new):
>
> drivers/usb/transceiver/
> drivers/usb/phy/
> drivers/usb/lowlevel/
>
> ?
>
> Otherwise, I will put it in drivers/usb/otg/ even of it doesn't look
> better to me but the chip is advertised as "OTG transceiver". ;-)

I don't know. Maybe Greg KH or Felipe Balbi will have a
recommendation. But any of these alternatives would be better than
drivers/usb/misc/.

Alan Stern



\
 
 \ /
  Last update: 2012-04-16 18:05    [W:0.048 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site