Messages in this thread | | | Date | Tue, 17 Apr 2012 00:54:01 +0900 | From | Takuya Yoshikawa <> | Subject | Re: [PATCH v2 04/16] KVM: MMU: return bool in __rmap_write_protect |
| |
On Mon, 16 Apr 2012 17:28:32 +0300 Avi Kivity <avi@redhat.com> wrote:
> > But the real question is whether there is any point in re-writing completely > > correct C code: there are tons of int like this in the kernel code. > > > > __rmap_write_protect() was introduced recently, so if this conversion is > > really worthwhile, I should have been told to use bool at that time, no? > > It's up to developer and maintainer preference. I like bool since it > documents the usage and is safer, but sometimes I miss it on review.
OK.
Thank you for your explanation!
Takuya
| |