lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [tip:perf/core] perf ui annotate browser: Allow toggling addr offset view
On Sun, Apr 15, 2012 at 11:25 PM, Masami Hiramatsu
<masami.hiramatsu.pt@hitachi.com> wrote:
>
> If we can ignore permissions, we can check whether the instruction
> at the event address is modified or not in /dev/mem.
> And that is also useful for modules. That can be done in userspace
> with using setuid'd tool.

No, please don't make a setuid tool for this.

It really would be *much* better if you could parse the
'altinstructions' section. You already have a lot of ELF parsing code.

Trust me, that's much better than trying to read the actual kernel
image - and makes things like off-line analysis easier too. The only
thing you need is the active CPU features (default to "current CPU
features"), rather than having to have the whole kernel image.

And no permission issues.

Linus


\
 
 \ /
  Last update: 2012-04-16 17:05    [from the cache]
©2003-2011 Jasper Spaans