lkml.org 
[lkml]   [2012]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 05/16] KVM: MMU: abstract spte write-protect
On 04/14/2012 10:26 AM, Takuya Yoshikawa wrote:

> On Fri, 13 Apr 2012 18:11:45 +0800
> Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
>
>> +/* Return true if the spte is dropped. */
>
> Return value does not correspond with the function name so it is confusing.
>


That is why i put comment here.

> People may think that true means write protection has been done.
>


You have a better name?



\
 
 \ /
  Last update: 2012-04-16 05:31    [W:0.152 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site