lkml.org 
[lkml]   [2012]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 12/37] atl1c: restore max-read-request-size in Device Conrol Register
Date


> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of Ben Hutchings
> Sent: Saturday, April 14, 2012 1:03
> To: Huang, Xiong
> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; qca-linux-team; nic-devel; linux-pci
> Subject: Re: [PATCH 12/37] atl1c: restore max-read-request-size in Device
> Conrol Register
>
> On Fri, 2012-04-13 at 08:14 +0800, xiong wrote:
> > in some platforms, we found the max-read-request-size in Device
> > Control Register is set to 0 by (BIOS?) during bootup, this will cause
> > the
> > performance(throughput) very bad.
> > Restore it to a min-value.
> > register definition of REG_DEVICE_CTRL is refined as well.
> [...]
>
> I'm guessing this memory-mapped register is an alias for the PCIe device control
> register. I think you should be using pcie_set_readrq() to ensure that the final
> setting conforms to the device's Max Payload Size and system policy.
>
You are right, I don't know there is a system function to do the right thing. I will revise it.

Thanks
Xiong

\
 
 \ /
  Last update: 2012-04-14 12:43    [W:0.038 / U:3.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site