lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
    On Thu, Apr 12, 2012 at 06:51:10PM +0100, Hugh Dickins wrote:
    > On Thu, 12 Apr 2012, Will Deacon wrote:
    >
    > > This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
    > > a quick fix suitable for -stable until ARM had been moved over to the
    > > gate_vma mechanism:
    > >
    > > https://lkml.org/lkml/2012/1/14/55
    > >
    > > With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
    > > mapping"), ARM does now use the gate_vma, so the PageReserved check can
    > > be removed from the proc code.
    > >
    > > Cc: Nicolas Pitre <nico@linaro.org>
    > > Signed-off-by: Will Deacon <will.deacon@arm.com>
    >
    > Oh, great, I'm glad that worked out: thanks a lot for looking after it,
    > Will, and now cleaning up afterwards.
    >
    > Acked-by: Hugh Dickins <hughd@google.com>

    Thanks, Hugh. I guess it's easiest if Andrew picks this one up as he took
    the original patch.

    Will

    > > ---
    > > fs/proc/task_mmu.c | 3 ---
    > > 1 files changed, 0 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
    > > index 2b9a760..2d60492 100644
    > > --- a/fs/proc/task_mmu.c
    > > +++ b/fs/proc/task_mmu.c
    > > @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
    > > if (!page)
    > > continue;
    > >
    > > - if (PageReserved(page))
    > > - continue;
    > > -
    > > /* Clear accessed and referenced bits. */
    > > ptep_test_and_clear_young(vma, addr, pte);
    > > ClearPageReferenced(page);
    > > --
    > > 1.7.4.1
    > >
    > >
    >


    \
     
     \ /
      Last update: 2012-04-13 11:25    [W:0.026 / U:121.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site