lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 0/3] task_work_add (was: task_work_queue)
    On 04/13, Linus Torvalds wrote:
    >
    > On Fri, Apr 13, 2012 at 7:12 PM, Oleg Nesterov <oleg@redhat.com> wrote:
    > >
    > > Changes based on review from Andrew:
    > >
    > >        - s/task_work_queue/task_work_add/
    > >
    > >        - don't create a secret dependency upon task_work.h
    > >          including sched.h in tracehook.h and keys/internal.h
    > >
    > >        - add more includes into task_work.[ch] to not rely
    > >          on "sched.h includes everything"
    >
    > I thought based on Andrew's comments that you were going to remove the
    > extra code to do FIFO for no obvious reason.

    No, I tried to defense fifo,

    > Apparently nothing
    > actually wanted/needed it,

    True, currently nothing. And most probably never will. task_work_add()
    should only be used for the "unlikely" events.

    > so why do it?

    I can remove it.

    But, unless you strongly object, personally I'd prefer to keep fifo.

    Once again. Imho of course, but fifo is simply "obviously better"
    from the common sense pov when it comes to submit-the-work-for-
    execution.

    For example. keyctl_session_to_parent() does _cancel only to protect
    from exploits doing keyctl(KEYCTL_SESSION_TO_PARENT) in an endless
    loop. It could simply do task_work_add(), but in this case we need
    fifo for correctness.

    But, again, again, I am not going to argue too much.

    Oleg.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-14 05:37    [W:0.021 / U:0.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site