[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] phonet: Sort out initiailziation and cleanup code.
    From: (Eric W. Biederman)
    Date: Fri, 06 Apr 2012 18:35:39 -0700

    > Recently an oops was reported in phonet if there was a failure during
    > network namespace creation.
    > After investigation it turns out there were two issues.
    > 1) Phonet was not implementing network devices but was using register_pernet_device
    > instead of register_pernet_subsys.
    > This was allowing there to be cases when phonenet was not initialized and
    > the phonet net_generic was not set for a network namespace when network
    > device events were being reported on the netdevice_notifier for a network
    > namespace leading to the oops above.
    > 2) phonet_exit_net was implementing a confusing and special case of handling all
    > network devices from going away that it was hard to see was correct, and would
    > only occur when the phonet module was removed.
    > Now that unregister_netdevice_notifier has been modified to synthesize unregistration
    > events for the network devices that are extant when called this confusing special
    > case in phonet_exit_net is no longer needed.
    > Signed-off-by: Eric W. Biederman <>

    Also applied, thanks Eric.

     \ /
      Last update: 2012-04-13 17:09    [W:0.021 / U:13.072 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site