lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call
Jeff Layton wrote:

+retry:
error = user_path_at(dfd, filename, lookup_flags, &path);
if (error)
goto out;
error = vfs_getattr(path.mnt, path.dentry, stat);
+ should_retry = error == -ESTALE ? retry_estale(path.dentry) : false;
path_put(&path);
+ if (should_retry) {
+ lookup_flags |= LOOKUP_REVAL;
+ goto retry;
+ }
out:
return error;
}
This is starting to look like FORTRAN. Maybe turn this into a "do while"?
Then you could make the "goto out" into a break and get rid of them both.


\
 
 \ /
  Last update: 2012-04-13 14:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site