lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] block: mtip32xx: remove HOTPLUG_PCI_PCIE dependancy
    On 04/12/2012 02:46 AM, Asai Thambi S P wrote:
    > On 4/11/2012 1:38 PM, Jens Axboe wrote:
    >
    >> On 2012-04-11 22:33, Asai Thambi S P wrote:
    >>> On 4/11/2012 12:57 PM, Jens Axboe wrote:
    >>>
    >>>> On 2012-04-11 20:34, Greg KH wrote:
    >>>>> This removes the HOTPLUG_PCI_PCIE dependency on the driver and makes it
    >>>>> depend on PCI.
    >>>>
    >>>> I think it's an old dependency. I've built and run it here without as
    >>>> well, and no functional issues either.
    >>>>
    >>>> Sam/Asai?
    >>>>
    >>>
    >>>
    >>> Both driver and device will work fine without PCIe hotplug dependency. This
    >>> dependency is required for supporting surprise removal and surprise insertion
    >>> of the device on systems with PCIe hotplug controller.
    >>
    >> That goes for all devices, though. So I think we can safely remove this
    >> dependency. Nobody should expect hotplug/removal to work, without
    >> actually including that :-)
    >>
    >> If you or Sam would formally ack the patch, then I'll add it to the
    >> pending mtip32xx series.
    >>
    >
    > Acked-by: Asai Thambi S P <asamymuthupa@micron.com>

    Thanks applied Gregs patch - I see the two of you battled it out while I
    was sound asleep ;-)

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2012-04-12 09:41    [W:4.705 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site