lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mm: set task exit code before complete_vfork_done()
On Thu, 12 Apr 2012 12:09:48 +0400
Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:

> kthread_stop() uses task->vfork_done for synchronization. The exiting kthread
> shouldn't do complete_vfork_done() until it sets ->exit_code.
>
> fix for mm-correctly-synchronize-rss-counters-at-exit-exec.patch
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> ---
> kernel/exit.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/exit.c b/kernel/exit.c
> index eb12719..70875a6 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -960,6 +960,9 @@ void do_exit(long code)
>
> acct_update_integrals(tsk);
>
> + /* Set exit_code before complete_vfork_done() in mm_release() */
> + tsk->exit_code = code;
> +
> /* Release mm and sync mm's RSS info before statistics gathering */
> mm_release(tsk, tsk->mm);
>
> @@ -975,7 +978,6 @@ void do_exit(long code)
> tty_audit_exit();
> audit_free(tsk);
>
> - tsk->exit_code = code;
> taskstats_exit(tsk, group_dead);
>

So does this patch address Oleg's objection to
mm-correctly-synchronize-rss-counters-at-exit-exec.patch?


\
 
 \ /
  Last update: 2012-04-13 01:37    [W:0.543 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site