Messages in this thread | | | Date | Thu, 12 Apr 2012 16:00:58 -0700 | From | Greg KH <> | Subject | Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs |
| |
On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > This patch creates sysfs file to export where VMCSINFO is allocated, > as below: > $ cat /sys/kernel/vmcsinfo > 1cb88a0 2000 > number on the left-hand side is the physical address of VMCSINFO, > while the one on the right-hand side is the max size of VMCSINFO.
Ick, why do you have 2 values in one sysfs file, that's not nice, or good.
What's wrong with 2 different files?
Also, any new sysfs file you add needs to also have a Documentation/ABI entry added as well.
But we can't accept this as-is, sorry, please split it up into 2 files.
greg k-h
| |