Messages in this thread | | | From | Grant Likely <> | Date | Thu, 12 Apr 2012 14:46:17 -0600 | Subject | Re: [PATCH] iqrdomain: Improve formatting in debugfs. |
| |
On Thu, Apr 12, 2012 at 2:38 PM, David Daney <ddaney.cavm@gmail.com> wrote: > On 04/12/2012 12:20 PM, Andreas Schwab wrote: >> >> Grant Likely<grant.likely@secretlab.ca> writes: >> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>> index 9310a8d..eb05e40 100644 >>> --- a/kernel/irq/irqdomain.c >>> +++ b/kernel/irq/irqdomain.c >>> @@ -643,8 +643,8 @@ static int virq_debug_show(struct seq_file *m, void >>> *private) >>> void *data; >>> int i; >>> >>> - seq_printf(m, "%-5s %-7s %-15s %-18s %s\n", "virq", "hwirq", >>> - "chip name", "chip data", "domain name"); >>> + seq_printf(m, "%-5s %-7s %-15s %-*s %s\n", "irq", "hwirq", >>> + "chip name", 2 * sizeof(void *) + 2, "chip data", >>> "domain name"); >> >> >> kernel/irq/irqdomain.c:647:9: warning: field width specifier ‘*’ expects >> argument of type ‘int’, but argument 6 has type ‘long unsigned int’ >> [-Wformat] >> > > My original patch assigned the size to an int variable and then passed that > to the seq_printf(), thus avoiding this issue. I suspect something like: > > s/2 * sizeof(void *) + 2/(int)(2 * sizeof(void *) + 2)/ > > Would do the trick.
Yeah, I'll push out a fixup patch.
g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |