[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] mm: page-writeback.c: local functions should not be exposed globally
    The function global_dirtyable_memory is only referenced in this file and
    should be marked static to prevent it from being exposed globally.

    This quiets the sparse warning:

    warning: symbol 'global_dirtyable_memory' was not declared. Should it be static?

    Signed-off-by: H Hartley Sweeten <>


    diff --git a/mm/page-writeback.c b/mm/page-writeback.c
    index 26adea8..9dec97f 100644
    --- a/mm/page-writeback.c
    +++ b/mm/page-writeback.c
    @@ -204,7 +204,7 @@ static unsigned long highmem_dirtyable_memory(unsigned long total)
    * Returns the global number of pages potentially available for dirty
    * page cache. This is the base value for the global dirty limits.
    -unsigned long global_dirtyable_memory(void)
    +static unsigned long global_dirtyable_memory(void)
    unsigned long x;

     \ /
      Last update: 2012-04-12 22:47    [W:0.020 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site