lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] iqrdomain: Improve formatting in debugfs.
    On 04/12/2012 12:20 PM, Andreas Schwab wrote:
    > Grant Likely<grant.likely@secretlab.ca> writes:
    >
    >> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
    >> index 9310a8d..eb05e40 100644
    >> --- a/kernel/irq/irqdomain.c
    >> +++ b/kernel/irq/irqdomain.c
    >> @@ -643,8 +643,8 @@ static int virq_debug_show(struct seq_file *m, void *private)
    >> void *data;
    >> int i;
    >>
    >> - seq_printf(m, "%-5s %-7s %-15s %-18s %s\n", "virq", "hwirq",
    >> - "chip name", "chip data", "domain name");
    >> + seq_printf(m, "%-5s %-7s %-15s %-*s %s\n", "irq", "hwirq",
    >> + "chip name", 2 * sizeof(void *) + 2, "chip data", "domain name");
    >
    > kernel/irq/irqdomain.c:647:9: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 6 has type ‘long unsigned int’ [-Wformat]
    >

    My original patch assigned the size to an int variable and then passed
    that to the seq_printf(), thus avoiding this issue. I suspect something
    like:

    s/2 * sizeof(void *) + 2/(int)(2 * sizeof(void *) + 2)/

    Would do the trick.

    David Daney

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-12 22:41    [W:0.021 / U:0.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site