lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Add CONFIG_READABLE_ASM
On Thu, Apr 12, 2012 at 09:47:19PM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Thu, Apr 12, 2012 at 21:40, Sam Ravnborg <sam@ravnborg.org> wrote:
> > On Thu, Apr 12, 2012 at 09:08:36PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Mar 28, 2012 at 20:51, Andi Kleen <andi@firstfloor.org> wrote:
> >> > +ifdef CONFIG_READABLE_ASM
> >> > +# Disable optimizations that make assembler listings hard to read.
> >> > +# reorder blocks reorders the control in the function
> >> > +# ipa clone creates specialized cloned functions
> >> > +# partial inlining inlines only parts of functions
> >> > +KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \
> >> > +                 $(call cc-option,-fno-ipa-cp-clone,) \
> >> > +                 $(call cc-option,-fno-partial-inlining)
> >> > +endif
> >
> > Could people move to this century and drop these ugly "\" line-continuations please...
> > People seems to get along in C without but think they should be used in Makefiles..
>
> Not without an additional patch for make:
>
> Makefile:575: *** missing separator (did you mean TAB instead of 8
> spaces?). Stop.

I meant like this:

KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks)
KBUILD_CFLAGS += $(call cc-disable-warning,-fno-ipa-cp-clone)
KBUILD_CFLAGS += $(call cc-option,-fno-partial-inlining)

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-12 21:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site