lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] Add CONFIG_READABLE_ASM
    On Thu, Apr 12, 2012 at 09:08:36PM +0200, Geert Uytterhoeven wrote:
    > Hi Andi,
    >
    > On Wed, Mar 28, 2012 at 20:51, Andi Kleen <andi@firstfloor.org> wrote:
    > > +ifdef CONFIG_READABLE_ASM
    > > +# Disable optimizations that make assembler listings hard to read.
    > > +# reorder blocks reorders the control in the function
    > > +# ipa clone creates specialized cloned functions
    > > +# partial inlining inlines only parts of functions
    > > +KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \
    > > +                 $(call cc-option,-fno-ipa-cp-clone,) \
    > > +                 $(call cc-option,-fno-partial-inlining)
    > > +endif

    Could people move to this century and drop these ugly "\" line-continuations please...
    People seems to get along in C without but think they should be used in Makefiles..


    > This (now in linux-next) causes m68k/allmodconfig to fail for me:
    >
    > CHK include/linux/version.h
    > CHK include/generated/utsrelease.h
    > CC kernel/bounds.s
    > cc1: error: unrecognized command line option "-fno-ipa-cp-clone"
    >
    > Somehow, "$(call cc-option,-fno-ipa-cp-clone,)" doesn't detect that my
    > toolchain (gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21))
    > doesn't support this option.
    >
    > I tried playing with the trailing comma (why do the first 2 tests have it,
    > and the 3rd one doesn't?), but that didn't make a difference.
    The trailing comma does not have any affect - it is only ugly and should be dropped.
    You should try cc-diasable-warning like this:

    KBUILD_CFLAGS += $(call cc-disable-warning, ipa-cp-clone)

    from Documentation/kbuild/makefiles.txt:

    cc-disable-warning
    cc-disable-warning checks if gcc supports a given warning and returns
    the commandline switch to disable it. This special function is needed,
    because gcc 4.4 and later accept any unknown -Wno-* option and only
    warn about it if there is another warning in the source file.

    Example:
    KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)

    In the above example, -Wno-unused-but-set-variable will be added to
    KBUILD_CFLAGS only if gcc really accepts it.


    The documentation refer to gcc 4.4 - but maybe the older gcc you have
    has the same behaviour.

    Sam
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-12 21:43    [W:0.024 / U:30.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site