lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 1/3] x86: introduce CONFIG_X86_DEV_DMA_OPS
On 03/13/2012 11:56 PM, Ingo Molnar wrote:
>
> * Alessandro Rubini <rubini@gnudd.com> wrote:
>
>> 32-bit x86 systems may need their own DMA operations, so add a
>> new config option, which is turned on for 64-bit systems. This
>> patch has no functional effect but it paves the way for
>> supporting the STA2x11 I/O Hub and possibly other chips.
>>
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
>> Cc: Alan Cox <alan@linux.intel.com>
>> ---
>> arch/x86/Kconfig | 5 +++++
>> arch/x86/include/asm/device.h | 4 ++--
>> arch/x86/include/asm/dma-mapping.h | 2 +-
>> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> Ok, the whole series looks pretty clean, modulo a few mostly
> cosmetic details in the driver itself.
>
> Andrew, you are typically merging dma-mapping.h patches, would
> you like to do these, or can we do it in tip:x86/platform?
>
> It would also be nice if the gents on Cc: would voice objections
> or approval, if any.
>

I looked over it, and at least this bit seems okay to me.

Acked-by: H. Peter Anvin <hpa@zytor.com>

Andrew, I guess the question is still open?

I have to express some concern about where this device may be going, though.

-hpa


\
 
 \ /
  Last update: 2012-04-12 20:05    [from the cache]
©2003-2011 Jasper Spaans