Messages in this thread | | | Date | Thu, 12 Apr 2012 13:15:12 -0400 | From | Paul Gortmaker <> | Subject | Re: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznet drivers |
| |
On 12-04-11 07:54 PM, David Miller wrote: > From: Paul Gortmaker <paul.gortmaker@windriver.com> > Date: Wed, 11 Apr 2012 19:50:55 -0400 > >> The use of IS_ENABLED in C code (vs just in CPP #if directives) >> causes us to carry the burden of a huge autoconf.h file. It is >> also misleading in that a casual inspection of the code would >> leave one thinking that the if statements were evaluated at >> runtime, when TX_FLOW is a Kconfig bool and hence evaluated >> at configure time as an either/or. >> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > Want me to toss this into net-next?
Yes, that makes sense since wiznet only exists there currently.
Thanks, Paul.
| |