[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug

> Hi Shuah,
> The fake _OST methods print arguments to verify successful execution of
> the methods. Since the purpose of _OST is firmware-internal
> communication, there is no difference in testing on real firmware from
> the OS perspective. Overriding DSDT with fake ACPI methods is a
> well-established and widely used testing method as well.


This patch hasn't gone through sufficient new functionality testing as
the only testing that was done was exercising it with stubbed out
firmware calls. I am not clear on how much regression testing this patch
has undergone. Sorry, it doesn't give me the warm and fuzzies.

-- Shuah

 \ /
  Last update: 2012-04-12 16:21    [W:0.048 / U:24.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site