lkml.org 
[lkml]   [2012]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Patch "USB: serial: mos7840: Supported MCS7810 device"
> +/* MCS7810 LED support */
> +#define MCS7810_HAS_LED

I would just enable this. Nobody is going to change it in their source
code.


> +#ifdef MCS7810_HAS_LED
> + /* Turn on MCS7810 LED */
> + if (serial->num_ports == 1 && mos7840_port->mos7810_led_flag == 0) {

Same comment as before about leds and flags to indicate features.

All these if cases should be a feature flag of some kind

Alan


\
 
 \ /
  Last update: 2012-04-12 11:49    [W:0.168 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site