Messages in this thread | | | Date | Thu, 12 Apr 2012 10:49:36 +0100 | From | Alan Cox <> | Subject | Re: Patch "USB: serial: mos7840: Supported MCS7810 device" |
| |
> +/* MCS7810 LED support */ > +#define MCS7810_HAS_LED
I would just enable this. Nobody is going to change it in their source code.
> +#ifdef MCS7810_HAS_LED > + /* Turn on MCS7810 LED */ > + if (serial->num_ports == 1 && mos7840_port->mos7810_led_flag == 0) {
Same comment as before about leds and flags to indicate features.
All these if cases should be a feature flag of some kind
Alan
| |