lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznet drivers
    Hi Dave,

    On Wed, 11 Apr 2012 19:54:44 -0400 (EDT) David Miller <davem@davemloft.net> wrote:
    >
    > From: Paul Gortmaker <paul.gortmaker@windriver.com>
    > Date: Wed, 11 Apr 2012 19:50:55 -0400
    >
    > > The use of IS_ENABLED in C code (vs just in CPP #if directives)
    > > causes us to carry the burden of a huge autoconf.h file. It is
    > > also misleading in that a casual inspection of the code would
    > > leave one thinking that the if statements were evaluated at
    > > runtime, when TX_FLOW is a Kconfig bool and hence evaluated
    > > at configure time as an either/or.
    > >
    > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    >
    > Want me to toss this into net-next?

    Sure - *after* it has been reviewed, and tested :-)

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-04-12 02:09    [W:0.510 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site