lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/5] kconfig: limit IS_ENABLED & similar to CPP usage
    On Wed, Apr 11, 2012 at 4:50 PM, Paul Gortmaker
    <paul.gortmaker@windriver.com> wrote:
    > Using IS_ENABLED() within C (vs. within CPP #if statements) requires
    > us to actually define every possible bool/tristate Kconfig option
    > twice (__enabled_* and __enabled_*_MODULE variants).

    Why do you keep the __enabled_*[_MODULE] things alive at all?

    Why can't you just check the CONFIG_xyz[_MODULE] #defines directly?

    IOW, why isn't IS_ENABLED() just

    #define IS_ENABLED(option) \
    (defined(CONFIG_##option) || defined(CONFIG_##option##_MODULE))

    #define IS_BUILTIN(option) \
    (defined(CONFIG_##option))

    and we're done with it all? What's the advantage of the __enabled_
    thing again, when you depend on the preprocessor anyway?

    Linus


    \
     
     \ /
      Last update: 2012-04-12 02:07    [W:0.019 / U:65.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site