lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 68/78] Fix length of buffer copied in __nfs4_get_acl_uncached
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sachin Prabhu <sprabhu@redhat.com>

    commit 20e0fa98b751facf9a1101edaefbc19c82616a68 upstream.

    _copy_from_pages() used to copy data from the temporary buffer to the
    user passed buffer is passed the wrong size parameter when copying
    data. res.acl_len contains both the bitmap and acl lenghts while
    acl_len contains the acl length after adjusting for the bitmap size.

    Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: Josh Boyer <jwboyer@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/nfs/nfs4proc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfs/nfs4proc.c
    +++ b/fs/nfs/nfs4proc.c
    @@ -3625,7 +3625,7 @@ static ssize_t __nfs4_get_acl_uncached(s
    if (acl_len > buflen)
    goto out_free;
    _copy_from_pages(buf, pages, res.acl_data_offset,
    - res.acl_len);
    + acl_len);
    }
    ret = acl_len;
    out_free:



    \
     
     \ /
      Last update: 2012-04-12 01:59    [W:0.041 / U:0.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site