Messages in this thread | | | Date | Wed, 11 Apr 2012 09:59:25 +0200 | Subject | Re: [PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant | From | Linus Walleij <> |
| |
On Tue, Apr 10, 2012 at 5:43 AM, Viresh Kumar <viresh.kumar@st.com> wrote: > On 4/10/2012 2:23 AM, Linus Walleij wrote:
>> + val = readl(ch->base + PL080_CH_CONFIG); >> + if (val & (PL080N_CONFIG_ITPROT | PL080N_CONFIG_SECPROT)) { >> + dev_info(&adev->dev, "physical channel %d reserved " >> + "for secure access only\n", i); > > Better not to break the print string. Go beyond 80 columns.
OK
>> + ch->locked = true; >> + } else >> + ch->locked = false; >> + } >> + > > Memory for ch is allocated with kmalloc and so its default value is garbage. > So we must set locked to false in else part here.
Hm maybe better to kzalloc() the channel structs?
>> @@ -2036,9 +2069,9 @@ static struct amba_id pl08x_ids[] = { >> }, >> /* Nomadik 8815 PL080 variant */ >> { >> - .id = 0x00280880, >> + .id = 0x00280080, > > Has this changed? How it worked earlier?
Never worked until now. It was based on incorrect data sheets...
I'll send a V2 ASAP.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |