lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] proc: use mm_access() instead of ptrace_may_access()
    Date
    mm_access() handles this much better, and avoids some race conditions.

    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
    ---
    fs/proc/base.c | 7 ++-----
    1 files changed, 2 insertions(+), 5 deletions(-)
    diff --git a/fs/proc/base.c b/fs/proc/base.c
    index 8608a4d..f1d18fc 100644
    --- a/fs/proc/base.c
    +++ b/fs/proc/base.c
    @@ -2035,11 +2035,8 @@ static int map_files_d_revalidate(struct dentry *dentry, struct nameidata *nd)
    if (!task)
    goto out_notask;

    - if (!ptrace_may_access(task, PTRACE_MODE_READ))
    - goto out;
    -
    - mm = get_task_mm(task);
    - if (!mm)
    + mm = mm_access(task, PTRACE_MODE_READ);
    + if (IS_ERR_OR_NULL(mm))
    goto out;

    if (!dname_to_vma_addr(dentry, &vm_start, &vm_end)) {
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-04-11 08:03    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean