lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic()
On Tue, Apr 10, 2012 at 12:19:49PM -0700, Andrew Morton wrote:
> On Mon, 09 Apr 2012 11:34:48 -0700
> Andi Kleen <ak@linux.intel.com> wrote:
>
> > > The proper way to resolve the problem that original commit tried to
> > > solve is to avoid printing a stack dump from panic() when the either
> > > of the following conditions is true:
> > >
> > > 1) TAINT_DIE has been set (this is done by oops_end())
> > > This indicates and oops has already been printed.
> > > 2) oops_in_progress> 1
> > > This guards against the rare case where panic() is invoked
> > > a second time, or in between oops_begin() and oops_end()
> >
> > Oops. I guess can just revert it for now. Thanks for catching, Jason.
>
> You're suggesting a revert of 6e6f0a1f0, but Jason is suggesting that
> it be repaired. Confused.

Repairing is fine too for me.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2012-04-11 01:31    [W:0.048 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site