Messages in this thread | | | Date | Tue, 10 Apr 2012 23:03:14 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 2/4] tools: Add a toplevel Makefile |
| |
On Tue, Apr 10, 2012 at 10:33:48PM +0200, Sam Ravnborg wrote: > Things would be much simpler is all tools were adjusted to: > a) the subdir they live in is the make target name > b) each tool has three mandatory targets: > 1) default target => build the tool > 2) clean > 3) install > > I can see that with the layout today you cannot > distingush between the various targets below power. > But the current solutions is not scaleable nor maintainable. > > Even if you cannot fix power/* then testing looks easy. > > But all that can always to improved and consolidated later.
Right, I was deliberating on whether to unify the dir layout so that it fits with the Makefile targets nicely but decided to leave it out for later. IOW, do the "one thing at a time" deal. Besides, some tools don't have that clearly defined targets and selftests, for example, doesn't need to be installed but simply run in a loop.
So definitely agreed, the tools/ dir could use a bunch of cultivating in later cycles.
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |